Scoped storage#2521
Conversation
|
Thanks for the pull request! Could you please split the separate changes to the sample app target SDK into a different PR? Could you please also provide a test plan for your change to verify that this doesn't break loading local URIs? |
This reverts commit 1e0110a.
|
Separate PR for samples #2522 |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@defHLT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
What is the status of this commit ? react-native uses this library for image component but android 10 and above is not supported. Since there are many layers of abstraction in react-native its time consuming to debug from where the issue happens. Request team to fix on priority basis. |
|
@paulmasters Could you please provide a test plan for your change to verify that this doesn't break loading local URIs? |
5 participants
Thanks for submitting a PR! Please read these instructions carefully:
masterbranchMotivation (required)
What existing problem does the pull request solve?
#2455
Access to file URIs is deprecated and MediaStore.Images.ImageColumns.DATA is deprecated so will fail in Android 10.
If we remove this and simply use the contentURL directly to open a stream that should work fine
Test Plan (required)
I did not get time to make a nice test case.
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
If you have added code that should be tested, add tests.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the Contributing guide.